Conversation
…eries Creating multiple instances in the same process (e.g. when broker module is imported more than once during fs-discover) now reuses already registered collectors instead of raising ValueError: Duplicated timeseries in CollectorRegistry. Closes taskiq-python#397, relates taskiq-python#173
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 85.37% 86.24% +0.87%
==========================================
Files 68 68
Lines 2660 2676 +16
==========================================
+ Hits 2271 2308 +37
+ Misses 389 368 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #397, relates #173.
Second PrometheusMiddleware() in the same process (e.g. broker module imported twice during --fs-discover) now reuses already-registered REGISTRY collectors instead of raising ValueError: Duplicated timeseries in CollectorRegistry.
Changes:
Verified: new tests 2 passed, middlewares+cli 83 passed, full suite 370 passed (1 unrelated flaky opentelemetry test passes in isolation), ruff/black/mypy clean.